Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Meenu/updated url for binary to deriv row users #7206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Meenu/updated url for binary to deriv row users #7206

wants to merge 1 commit into from

Conversation

@meenakshi-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
binary-static ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 11:06AM (UTC)

@github-actions
Copy link

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/binary-static/pull/7206](https://github.com/binary-com/binary-static/pull/7206)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-meenakshi-deriv-meenu-update-new-e623f6.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=31193
    - **Original**: https://binary-static-git-fork-meenakshi-deriv-meenu-update-new-e623f6.binary.sx/en/logged_inws.html
- **App ID**: `31193`

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

habib-deriv
habib-deriv reviewed Aug 25, 2022
View reviewed changes
src/javascript/app/common/redirect_banner.js

const handleRedirect = () => {
window.location.href = '/move-to-deriv/';
window.location.href = 'https://www.binary.bot/movetoderiv.html';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/move-to-deriv/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @habib-deriv @meenakshi-deriv the new one is /binary-to-deriv/ which we need to append to the url. We won’t need any redirection I think. 🤔

binary.com/binary-to-deriv/

mitra-deriv
mitra-deriv reviewed Aug 26, 2022
View reviewed changes
src/javascript/app/common/redirect_banner.js

const handleRedirect = () => {
window.location.href = '/move-to-deriv/';
window.location.href = 'https://www.binary.bot/movetoderiv.html';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @habib-deriv @meenakshi-deriv the new one is /binary-to-deriv/ which we need to append to the url. We won’t need any redirection I think. 🤔

binary.com/binary-to-deriv/

src/javascript/app/common/redirect_banner.js
// Check if param have ?binary-com-lp
const redirectBinary = new URLSearchParams(window.location.search);

if (redirectBinary.has('binary-com-lp') || Cookies.get('binary-com-show')){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don’t need this binary-com-lp check here anymore cause the changes will be in binary itself now.
We just need to append /binary-to-deriv/ once the client country is rest of the world.

@habib-deriv please correct me if I'm wrong 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mitra-deriv mitra-deriv mitra-deriv left review comments

@habib-deriv habib-deriv habib-deriv left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meenakshi-deriv @mitra-deriv @habib-deriv